Skip to content

Revert "ref(core): Wrap scopes in WeakRef when storing scopes on spans" #17731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Revert "ref(core): Wrap scopes in WeakRef when storing scopes on spans" #17731

wants to merge 1 commit into from

Conversation

andreiborza
Copy link
Member

Reverts #17712

Keeping this ready just in case there are issues with the WeakRef approach.

@andreiborza andreiborza self-assigned this Sep 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.23 kB -0.13% -31 B 🔽
@sentry/browser - with treeshaking flags 22.74 kB -0.14% -31 B 🔽
@sentry/browser (incl. Tracing) 40.34 kB -0.17% -66 B 🔽
@sentry/browser (incl. Tracing, Replay) 78.72 kB -0.07% -53 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.38 kB -0.1% -62 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 83.39 kB -0.06% -50 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 95.59 kB -0.07% -66 B 🔽
@sentry/browser (incl. Feedback) 40.95 kB -0.06% -24 B 🔽
@sentry/browser (incl. sendFeedback) 28.88 kB -0.12% -34 B 🔽
@sentry/browser (incl. FeedbackAsync) 33.8 kB -0.14% -45 B 🔽
@sentry/react 25.94 kB -0.14% -36 B 🔽
@sentry/react (incl. Tracing) 42.32 kB -0.16% -64 B 🔽
@sentry/vue 28.72 kB -0.22% -63 B 🔽
@sentry/vue (incl. Tracing) 42.14 kB -0.16% -65 B 🔽
@sentry/svelte 24.25 kB -0.19% -45 B 🔽
CDN Bundle 25.74 kB -0.11% -28 B 🔽
CDN Bundle (incl. Tracing) 40.16 kB -0.21% -83 B 🔽
CDN Bundle (incl. Tracing, Replay) 76.38 kB -0.1% -74 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 81.88 kB -0.09% -73 B 🔽
CDN Bundle - uncompressed 75.23 kB -0.19% -142 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 118.89 kB -0.21% -239 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 234.01 kB -0.11% -239 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 246.78 kB -0.1% -239 B 🔽
@sentry/nextjs (client) 44.34 kB -0.14% -62 B 🔽
@sentry/sveltekit (client) 40.76 kB -0.15% -61 B 🔽
@sentry/node-core 49.98 kB -0.08% -40 B 🔽
@sentry/node 152.19 kB -0.05% -61 B 🔽
@sentry/node - without tracing 91.88 kB -0.07% -59 B 🔽
@sentry/aws-serverless 105.33 kB -0.06% -62 B 🔽

View base workflow run

@github-actions GitHub Actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,078 - 9,362 -3%
GET With Sentry 1,407 15% 1,364 +3%
GET With Sentry (error only) 6,013 66% 6,234 -4%
POST Baseline 1,212 - 1,216 -0%
POST With Sentry 548 45% 530 +3%
POST With Sentry (error only) 1,057 87% 1,064 -1%
MYSQL Baseline 3,309 - 3,339 -1%
MYSQL With Sentry 472 14% 464 +2%
MYSQL With Sentry (error only) 2,673 81% 2,745 -3%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreiborza andreiborza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreiborza